util: Fix upper bound in parseUIntNoThrow#2349
Open
cuiweixie wants to merge 1 commit into
Open
Conversation
|
This patch doesn't work, modify it like this: |
Use strtoul and unsigned long so parsing matches uint32_t semantics, and cap the result at UINT32_MAX. The previous strtol path could not represent the full uint32_t range correctly on LP64 platforms.
9a35f45 to
ce82c20
Compare
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseUIntNoThrow writes to uint32_t but compared against std::numeric_limits<int32_t>::max(), rejecting valid values in (INT32_MAX, UINT32_MAX]. Compare against uint32_t max instead.