Skip to content

fix: update okhttp to latest version#396

Open
izaaz wants to merge 1 commit into
mainfrom
AMP-96260/update_okhttp
Open

fix: update okhttp to latest version#396
izaaz wants to merge 1 commit into
mainfrom
AMP-96260/update_okhttp

Conversation

@izaaz

@izaaz izaaz commented Mar 28, 2024

Copy link
Copy Markdown
Contributor

Updating okhttp to the latest version

@justin-fiedler justin-fiedler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but changing OkHttp sometimes causes issues. Need to look something up and get back to you.

@justin-fiedler justin-fiedler self-requested a review March 28, 2024 23:46
Comment thread build.gradle
dependencies {
implementation 'com.amplitude:analytics-connector:1.0.0'
implementation 'com.squareup.okhttp3:okhttp:4.2.2'
implementation 'com.squareup.okhttp3:okhttp:4.12.0'

@justin-fiedler justin-fiedler Mar 28, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a heads up in case we start getting new support requests for Accessing hidden method Lcom/android/org/conscrypt/OpenSSLSocketImpl or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants