fix(test): improve asyncio.sleep use reliability#2961
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The Background agent test
test_delivery_via_enqueueisn't reliable on the GitHub runner, likely due to some kind of resource contention.test_delivery_via_enqueueverifies that a background agent's result reaches the orchestrator's LLM before the final reply. Thewait_for_bgtool polls two signals,ctx.pending_messages(not yet drained) andDrainedModelRequestin stream history (already drained) - because_call_clientdrains the inbox before each LLM call, meaning the message can disappear frompending_messagesbeforewait_for_bgruns. Both checks together cover both timing orderings of the asyncio race.Similarly, the Network had two tests which relied on
asyncio.sleepand have now been updated to be more deterministic.Related issue number
N/A
Checks
AI assistance