feat: Move VaultDelete invariants from ValidVault to VaultDelete#7436
Draft
Tapanito wants to merge 1 commit into
Draft
feat: Move VaultDelete invariants from ValidVault to VaultDelete#7436Tapanito wants to merge 1 commit into
Tapanito wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ttVAULT_DELETE-specific invariant checks fromValidVault::finalizeintoVaultDelete::visitInvariantEntry/VaultDelete::finalizeInvariants, following the same pattern established forVaultCreatein the parent branch.VaultInvariantDatawith abeforeMPTs_vector and afindDeletedShares(mptID)accessor soVaultDeletecan locate the deletedMPTokenIssuancewithout depending onValidVault's internals.ValidVaultis kept — it guards against any non-ttVAULT_DELETEtransaction that inadvertently deletes a vault entry. The "vault deletion succeeded without deleting a vault" sentinel (triggered whenttVAULT_DELETEruns but the vault still exists) is now owned byVaultDelete::finalizeInvariants. The delete-specific emptiness checks (no shares, no assets total, no assets available) are also moved toVaultDelete.Checks moved from ValidVault → VaultDelete
afterVaults().empty()— vault was actually deleted (sentinel)findDeletedShares(shareMPTID)found — shares issuance was also deletedsharesTotal == 0— no outstanding shares at deletion timebeforeVault.assetsTotal == 0— no assets outstandingbeforeVault.assetsAvailable == 0— no assets availableTest plan
./xrpld -u Vault,Invariantspasses with 437 cases, 0 failures