Fixes SemanticDataStorageDBIntegrationTest by YOUR1 · Pull Request #6076 · SemanticMediaWiki/SemanticMediaWiki

YOUR1 · 2025-03-03T11:55:31Z

Summary by CodeRabbit

Tests
- Consolidated the setup process for verifying semantic data to improve efficiency.
- Added checks to ensure essential test data is present before validation, enhancing test reliability.

Fix regarding SemanticMediaWiki#6047 (comment)

Fixes testcase

coderabbitai · 2025-03-03T11:55:38Z

Walkthrough

The changes involve refactoring the test setup in the integration test file by consolidating page creation into a single helper method, createTestPages(). The two affected test methods now utilize this method instead of manually creating page objects. Additionally, extra assertions have been introduced to confirm the existence of the pages before further semantic data verification. A new private helper method encapsulates the page creation logic to promote cleaner and more reusable test code.

Changes

File	Change Summary
tests/phpunit/…/SemanticDataStorageDBIntegrationTest.php	Refactored `testPrepareToFetchCorrectSemanticDataFromInternalCache` & `testVerifyToFetchCorrectSemanticDataFromInternalCache` to use `createTestPages()`; added assertions in the latter; introduced new private helper method `createTestPages()` to encapsulate page creation.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b234f75 and e35d05f.

📒 Files selected for processing (1)

tests/phpunit/Integration/SemanticDataStorageDBIntegrationTest.php (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

tests/phpunit/Integration/SemanticDataStorageDBIntegrationTest.php

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: build (1.43, 8.2, mysql, mariadb:11.2, false, true)
GitHub Check: build (1.42, 8.2, mysql, mariadb:11.2, false, true)
GitHub Check: build (1.41, 8.1, mysql, mariadb:11.2, true, false)
GitHub Check: build (1.40, 8.1, mysql, mariadb:11.2, false, false)
GitHub Check: build (1.39, 8.1, mysql, mysql:8, false, false)
GitHub Check: build (1.39, 8.1, mysql, mariadb:11.2, false, false)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

tests/phpunit/Integration/SemanticDataStorageDBIntegrationTest.php (1)
292-299: Improved test robustness with existence assertions.

The extra assertions to verify page existence before running tests is an excellent practice. This helps to catch setup issues early and make test failures more obvious, rather than having confusing failures that stem from setup problems.

One minor suggestion: Consider adding more descriptive error messages that might include the page titles to help with debugging.
-$this->assertTrue($redirect->getTitle()->exists(), 'Redirect page should exist');
-$this->assertTrue($target->getTitle()->exists(), 'Target page should exist');
+$this->assertTrue($redirect->getTitle()->exists(), 'Redirect page "' . $redirect->getTitle() . '" should exist');
+$this->assertTrue($target->getTitle()->exists(), 'Target page "' . $target->getTitle() . '" should exist');

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b098554 and b234f75.

📒 Files selected for processing (1)

tests/phpunit/Integration/SemanticDataStorageDBIntegrationTest.php (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: build (1.43, 8.2, mysql, mariadb:11.2, false, true)
GitHub Check: build (1.42, 8.2, mysql, mariadb:11.2, false, true)
GitHub Check: build (1.41, 8.1, mysql, mariadb:11.2, true, false)
GitHub Check: build (1.40, 8.1, mysql, mariadb:11.2, false, false)
GitHub Check: build (1.39, 8.1, mysql, mysql:8, false, false)
GitHub Check: build (1.39, 8.1, mysql, mariadb:11.2, false, false)

🔇 Additional comments (2)

tests/phpunit/Integration/SemanticDataStorageDBIntegrationTest.php (2)

275-277: Good refactoring to extract test page creation!

This refactoring nicely separates the test page creation from the actual test logic, making the test method more focused on what it's testing rather than the setup details.

314-333: Well-structured helper method with clear documentation.

The new createTestPages() method is well-implemented with:

Good documentation explaining its purpose

Clear return type documentation

Thoughtful comments about page lifecycle management

Clean organization of the page creation logic

This refactoring makes the test code more maintainable and easier to understand.

YOUR1 · 2025-03-03T12:03:06Z

@paladox can you verify?

Seems like the @depends doesn't do what it supposed to do (keep the redirect and target page 'alive').

CS

codecov · 2025-03-03T12:30:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (b098554) to head (e35d05f).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #6076   +/-   ##
=========================================
  Coverage     56.92%   56.92%           
  Complexity    18942    18942           
=========================================
  Files           942      942           
  Lines         66899    66899           
=========================================
  Hits          38079    38079           
  Misses        28820    28820

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

paladox · 2025-03-03T13:19:29Z

@paladox can you verify?

Seems like the @depends doesn't do what it supposed to do (keep the redirect and target page 'alive').

Tests are passing? But I'm not an expert in tests. You could try and make a bogus test and see if it fails?

paladox · 2026-03-28T23:58:44Z

Merge conflicts need resolving.

YOUR1 added 6 commits February 19, 2025 11:07

Update RecursiveTextProcessor.php

81bb248

Fixed SemanticMediaWiki#5872

Update RecursiveTextProcessor.php

57f2af9

Fix regarding SemanticMediaWiki#6047 (comment)

Merge branch 'SemanticMediaWiki:master' into master

8cb95c4

Merge branch 'SemanticMediaWiki:master' into master

96db2f0

Merge branch 'SemanticMediaWiki:master' into master

07413ca

Update SemanticDataStorageDBIntegrationTest.php

b234f75

Fixes testcase

coderabbitai Bot reviewed Mar 3, 2025

View reviewed changes

Update SemanticDataStorageDBIntegrationTest.php

e35d05f

CS

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixes SemanticDataStorageDBIntegrationTest#6076

Fixes SemanticDataStorageDBIntegrationTest#6076
YOUR1 wants to merge 7 commits into
SemanticMediaWiki:masterfrom
YOUR1:fix-semanticstorage-db-integrationtest

YOUR1 commented Mar 3, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 3, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

YOUR1 commented Mar 3, 2025

Uh oh!

codecov Bot commented Mar 3, 2025

Uh oh!

paladox commented Mar 3, 2025

Uh oh!

paladox commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

YOUR1 commented Mar 3, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

YOUR1 commented Mar 3, 2025

Uh oh!

codecov Bot commented Mar 3, 2025

Codecov Report

Uh oh!

paladox commented Mar 3, 2025

Uh oh!

paladox commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

YOUR1 commented Mar 3, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)